sifive / wake

The SiFive wake build tool
Other
86 stars 28 forks source link

rsc: Enable RSC to build with rust 1.8 #1621

Closed V-FEXrt closed 1 month ago

V-FEXrt commented 1 month ago

One of the RSC's dependencies doesn't build against rust 1.8 which GHActions is now using by default. This PR updates the deps so that CI can pass again

V-FEXrt commented 1 month ago

is that deliberate

nope, just forgot about it

Though looks like rocky8 requires an older version of rust? this might be a pain

ag-eitilt commented 1 month ago

Yeah, that will definitely make things interesting. And the only reason I noticed the missing file was because I went through the list of dependabot warnings to see what this would clear up (answer: a fair number of the Rust ones, but since the majority of issues are with JavaScript we'll still definitely have a good few left).

V-FEXrt commented 1 month ago

but since the majority of issues are with JavaScript

I swear one day I'm going to remake the VSCode extension now that I know the proper way to do it