search

signalfx / gdi-specification

Splunk GDI specification for cross-repository compatibility
Apache License 2.0
3 stars 15 forks source link

Fix permissions to be applicable for non-instrumentation repositories #256

Closed pellared closed 1 year ago

pellared commented 1 year ago

Blocker for https://github.com/signalfx/gdi-specification/issues/254

The current repository permissions does not make sense for repos such us https://github.com/signalfx/splunk-otel-collector, https://github.com/signalfx/splunk-otel-collector-operator, https://github.com/signalfx/splunk-otel-collector-chart, https://github.com/signalfx/splunk-otel-collector-heroku

pellared commented 1 year ago

@mateuszrzeszutek @Kielek PTAL

Related PR https://github.com/signalfx/gdi-specification/pull/252

breedx-splk commented 1 year ago

Can you elaborate on why you think we need an additional "admin" team? Aren't the maintainers basically admins?

pellared commented 1 year ago

Can you elaborate on why you think we need an additional "admin" team? Aren't the maintainers basically admins?

We have gdi-instrumentation-admins team which is added to most (all?) our GDI instrumentation repositories, the other "admin" team is gdi-data-collection-admins.

pellared commented 1 year ago

I think I'm fine with that, although I'd prefer the doc to say "at least one of these two teams" explicitly.

I think we can refine this in a bugfix release. You can also propose a change if you already have an idea how to define it.

Can you elaborate on why you think we need an additional "admin" team? Aren't the maintainers basically admins?

Same as above 😉