signalfx / gdi-specification

Splunk GDI specification for cross-repository compatibility
Apache License 2.0
3 stars 15 forks source link

Clarify default sampling algorithm #283

Closed seemk closed 10 months ago

seemk commented 10 months ago

OpenTelemetry defaults to parentbased_always_on, but this is not consistent across our distributions:

If we are advertising as a no sampling solution, we should default to always_on, but still allow for customers to change it. Using parentbased_always_on can cause data loss if customers have previously set up cloud tracing, which injects a traceparent with 00 for traceflags.