signaturescience / fiphde

Forecasting Influenza in Support of Public Health Decision Making
https://signaturescience.github.io/fiphde/
GNU General Public License v3.0
3 stars 2 forks source link

TSENS fails with sharp increases #135

Closed stephenturner closed 1 year ago

stephenturner commented 1 year ago

If there is a sharp increase in the number of events (e.g., hospitalizations), the TSENS model will fail. A few recent examples showing locations for influenza hospitalizations where TSENS failed (the green band is the CREG model used in the submission.R script at the project root, ignore these):

image image image image

stephenturner commented 1 year ago

Editing the submission script to remove the ARIMA model restrictions:

hosp_fitfor <- ts_fit_forecast(prepped_hosp_tsibble,
                               horizon=4L,
                               outcome="flu.admits",
                               covariates=c("hosp_rank", "ili_rank"),
                               stepwise=FALSE, approximation=FALSE,
                               models=list(arima='PDQ() + pdq()',
                                           ets='season(method="N")',
                                           nnetar=NULL))

Results in no null model / failures to converge. Note the extremely and implausibly sharp increase in forecasted hospitalizations.

image

image

The above plots show the unrestricted ARIMA model. Below show the same locations (CA and US) with the ETS model ensembled.

image

image

We might consider removing the ARIMA restrictions (with retrospective evaluation). Modifying the ts_fit_forecast() function to conditionally remove restrictions for a specific location in the event of a model failure at one or more locations will be difficult. Conditionally removing restrictions and re-running in the event of a null model / failure is more tractable, but should necessitate some retrospective evaluation of performance against the restricted model.

stephenturner commented 1 year ago

Closing for now. Reopening if this persists, possible to consider relaxing constraints on ARIMA after retrospective evaluation.

stephenturner commented 1 year ago

Code in dd6728e to remove restrictions.