search

signaturescience / fiphde

Forecasting Influenza in Support of Public Health Decision Making
https://signaturescience.github.io/fiphde/
GNU General Public License v3.0
3 stars 1 forks source link

no longer export glm helpers #152

Closed vpnagraj closed 1 year ago

vpnagraj commented 1 year ago

some of the helper functions for our glm modeling/forecasting features may not need to be exported.

lets consider ...

https://github.com/signaturescience/fiphde/blob/main/R/glm.R#L66-L95

https://github.com/signaturescience/fiphde/blob/main/R/glm.R#L98-L155

vpnagraj commented 1 year ago

lets not export glm_fit, glm_forecast, or glm_quibble

vpnagraj commented 1 year ago

fixed in https://github.com/signaturescience/fiphde/commit/f71610f4e5a1e6d29a0fb6bd40740b808c139082

pushed directly to v1.0.0 branch cc @stephenturner