signaturescience / fiphde

Forecasting Influenza in Support of Public Health Decision Making
https://signaturescience.github.io/fiphde/
GNU General Public License v3.0
3 stars 2 forks source link

make model names in ts_fit_forecast more flexible #157

Closed vpnagraj closed 1 year ago

vpnagraj commented 1 year ago

the list of models names passed to ts_fit_forecast() is very strict when it comes to the named elements passed to the "models" argument. it is case sensitive (if you pass in a list with an element named "ARIMA" instead of "arima" it will assume ARIMA is NULL) and doesnt allow you to pass in different "flavors" of models (e.g., a list with "arima_unrestricted" and "arima_restricted" side-by-side).

is there a way we can make the handling of model names more flexible?

stephenturner commented 1 year ago

Made case-insensitive in b0a1947a62229b6dd2de52dbb40dcb57285a5c58 coming in on PR #170

stephenturner commented 1 year ago

closed in #170