Closed stephenturner closed 1 year ago
@vpnagraj check that you like the thing I did in that last commit described above. I'd rather do this once here than try to remember to do this median imputation whenever we do this in a submission script after #159
── R CMD check results ───────────────────────────────────────────────────────────────── fiphde 0.3.4 ────
Duration: 41.6s
0 errors ✔ | 0 warnings ✔ | 0 notes ✔
R CMD check succeeded
looks great!
fixes #161
data saved as a csv in data-raw and as unexported package data (
ilinearby
).Note we have data covering the critical window between where ilinet starts and ilinearby ends (right hand side of the plot, overlapping green tiles).
Showing the first cut at this in fd636f5:
If you look closely enough, you'll see we still have that that weird thing happening at 2020:53
We dealt with this with a quick "impute" method in the function:
https://github.com/signaturescience/fiphde/blob/87c8d97c607c93c3ff47f3727056df597bf5505c/R/utils.R#L108-L113
I dealt with this in generate_sysdata in 83e179eea097c92f8e2390662aad0f660d665d40.
Now we have complete data for FL going back to ~2011.