signaturescience / fiphde

Forecasting Influenza in Support of Public Health Decision Making
https://signaturescience.github.io/fiphde/
GNU General Public License v3.0
3 stars 1 forks source link

Remove covariates choices, make TRUE/FALSE; model name case insensitivity #170

Closed stephenturner closed 1 year ago

stephenturner commented 1 year ago

covariates=c("hosp_rank", "ili_rank") to covariates=TRUE. (kind of) fixes #158

Default is covariates=TRUE, which triggers this reassignment:

https://github.com/signaturescience/fiphde/blob/333129dad4b43d0ff1871eba9eb58216955007cd/R/forecast.R#L68-L76

Which allows code to continue working as is, and other non-flu hosp forecasting can use either NULL or FALSE to achieve the same end, which won't cause a breaking change with other types of forecasting.

also makes model list objects case insensitive #157

Note PR into v1.0.0 not main