search

signaturescience / fiphde

Forecasting Influenza in Support of Public Health Decision Making
https://signaturescience.github.io/fiphde/
GNU General Public License v3.0
3 stars 1 forks source link

Added loader on busy #176

Closed dwill023 closed 1 year ago

dwill023 commented 1 year ago

I've added a loader to the /inst/app/app.R file using the library(waiter). This creates a spinner when the server is busy rendering and plotting.

vpnagraj commented 1 year ago

@dwill023 thanks for working on this. ill review this shortly. can you also click the request review button on this PR? (i am testing out some branch protection rules that require us to request review before these can be merged)

also FYI this has flagged an unrelated issue (see #177 ) that i am catching thanks to the automated CI/CD package check:

https://github.com/signaturescience/fiphde/actions/runs/4952653456/jobs/8859225690?pr=176

pays to have that wired up!

vpnagraj commented 1 year ago

this looks great @dwill023 !

BUT in working on this (like i mentioned above) we are seeing another bug to fix with breaking changes in the new trendeval API.

what im going to propose is that we actually close this PR and open a new PR from the shiny_app branch to v1.1.0 branch. we will fold in a few other things into that branch and once ready will do a PR from v1.1.0 directly to main and cut a new release.

please open a new PR from shiny_app branch to v1.1.0 ... and use that shiny_app branch to address the comment i just posted re: Suggests (https://github.com/signaturescience/fiphde/issues/175#issuecomment-1546676366)