signaturescience / fiphde

Forecasting Influenza in Support of Public Health Decision Making
https://signaturescience.github.io/fiphde/
GNU General Public License v3.0
3 stars 1 forks source link

conditionally include nnetar in time series ensemble function #208

Closed vpnagraj closed 4 months ago

vpnagraj commented 4 months ago

while we do currently have an option to specify a NNETAR model, it is not included in the ensemble:

https://github.com/signaturescience/fiphde/blob/main/R/forecast.R#L125-L132

we should add a step to conditionally include the NNETAR in the ensemble if it is not NULL in model list

vpnagraj commented 4 months ago

done and on dev as https://github.com/signaturescience/fiphde/tree/dev