sikher / gurbanidb

An API for the Sikh Scriptures using the Laravel PHP framework
https://api.sikher.com
18 stars 4 forks source link

Adding in other datasets, including Siri Dasam Granth Sahib Ji #10

Open irvanjitsingh opened 9 years ago

irvanjitsingh commented 9 years ago

I think this is worth putting up as an issue, even if the timeframe isn't as immediate. Regardless of the concerns of the quality of meta-data or character formatting of associated with the other datasets (if that's still an issue), the data for the Gurmukhi exists in ASCII, and so it should be added to this project. There are several translation languages in the version 2.2 of this database that are still machine translations, and so, from the perspective of quality and accuracy, they too are sub-par, but the goal of a project like this should be to encourage further development of the existing resources that we already have, and so adding in other datasets can only be a boon for developers and sangat alike.

jasdeepkhalsa commented 9 years ago

I agree we should start including these now - especially since you can't even complete the Nitnem without the Dasam Granth

sukhpalsingh commented 8 years ago

I have got shri dasam granth sahib scripture in a database. How can i contribute my work to this database? I understand that this will be start of having these scripture available and then all of us can contribute to this scripture to make as accurate as possible.

jasdeepkhalsa commented 8 years ago

@sukhpalsingh If you email it over to us at info@sikher.com, we will look into the best way of integrating it into GurbaniDB

sukhpalsingh commented 8 years ago

sure. will do this weekend then.

jasdeepkhalsa commented 8 years ago

Any progress on that @sukhpalsingh ?

sukhpalsingh commented 8 years ago

Hi @jasdeepkhalsa I have sent email to info@sikher.com with the sql changes for shri dasam granth sahib scriptures.

Thanks

jasdeepkhalsa commented 8 years ago

Thanks @sukhpalsingh ! I've received that now, I'll take a look :)

kee23 commented 8 years ago

+1 for requesting Sri Dasam Granth Sahib Ji be added. Also looking at v2 of the database, I don't see Punjabi for the translations table. Is this data available to you guys?

jasdeepkhalsa commented 8 years ago

@kee23 At the moment we do not have this data unfortunately, but we're also not so keen to add it unless it has some enormous benefit that we've not considered because it bloats the size of the database which slows down the app.

Statistically Punjabi only accounts for about 1.44% of native speakers (https://en.wikipedia.org/wiki/List_of_languages_by_number_of_native_speakers) whereas languages like Spanish and English are over 5%. Therefore, applying the 80/20 rule, we should focus on where there is most benefit & impact for the least amount of effort. I'd personally be more keen to add in Spanish than Punjabi!

I would welcome other perspectives on the issue.

kee23 commented 8 years ago

Hi @jasdeepkhalsa, understood. I agree Punjabi is spoken and read by a small percentage of people worldwide, and since Gurbani is for anyone and everyone in the world to read, this logic makes sense.

I thought if the data was readily available, it would be nice to have. My goal is to potentially use this data in Gurdwaras where the scriptures could be displayed. I think Punjabi translations would be useful for an audience in that setting.

But regardless, thank you for this project! It's definitely a boon to us developers to have a quality source for SGGS. Having the Sri Dasam Granth Sahib Ji too one day would be awesome as well.

sukhpalsingh commented 8 years ago

I can get the punjabi translation easily but issue is with the copyright of the translation. I tried to contact Kulbir S Thind who is owner of gurbanifiles.org and also tried to contact the current maintainer of the punjabi teeka but they did not give me permission to add punjabi translation in the database.

If someone can get the permission of any punjabi teeka, i can get the data included easily as I could not get such permission.

jasdeepkhalsa commented 8 years ago

@kee23 Thanks for the response! Yes I agree, it's definitely useful to have the data available. Thinking about it again, we could add in additional translations which cannot fit into the core database as optionally downloadable add ons / files. We've done this in the past for developers so there's no harm in doing this again.

@sukhpalsingh Yes, certainly there is a copyright issue here. Although I doubt anyone consulted Bhai Manmohan Singh (who passed on in 1969) as to whether he is comfortable with the digitisation of his work from the printed publications by SGPC, because even if the data changes form from printed to digital, legally speaking (and I'm not saying this as a legal expert) the copyright usually remains with the original author i.e. Bhai Manmohan Singh. Under copyright law of India his work would enter into public domain at the end of 2029, which was the date of his passing and the final date of the publication of the last volume of his work. Before that however, it cannot be determined whether anyone really holds the legal authority to decide what happens to his work except himself, and unfortunately we cannot ask him. So before making any translation available we would have to seek some legal advice on this issue.

bogas04 commented 8 years ago

Thanks a lot for this awesome api.

Would love to know the status of adding SDG and other baanis to api.sikher, without translation for time-being.

Thanks once again

asingh-dev commented 7 years ago

WJKWJF,

You guys are doing a great job. I am also working on an app related to sikhi and I need some help in getting gurbani data (in gurmukhi) in either JSON or XML format. I know my question is not related to this issue :/ I will really appreciate if anyone can help me with this.

Thanks, Aman

sukhpalsingh commented 7 years ago

Hi Amandeep,

Not sure about the platform you are going to use for creating the app. If it is mobile related, then you can use the existing sqlite database that we already have in Sikher app.

If you want json format, you can find a tool online to convert sqlite to json or can be done manually also by running query and dumping the results to the json.

Thanks

asingh-dev commented 7 years ago

Hi Sukhpal,

Thank you. SQLITE DataBase will work.

Thanks again.

bogas04 commented 7 years ago

@amandeeepsingh

Sorry for referencing other Open Source project, but you might be interested in Khajana API by KhalisFoundation. A REST API to query Gurbani, with JSON responses.

Several internal apps already use it. [1] [2]

jasdeepkhalsa commented 7 years ago

@bogas04 Thanks for the fantastic links! And don't be sorry, in Sikhi all seva is complimentary - there is no concept of competition

asingh-dev commented 7 years ago

Thank you @bogas04. Your links are really helpful.

bogas04 commented 7 years ago

@amandeeepsingh @jhbsk Thank you!

I've abstracted it to a js module, with some demos: [1] [2]

jasdeepkhalsa commented 7 years ago

@bogas04 That's fantastic work! Really gives people more of an idea how to use that API, as it seems like the repo is currently empty: https://github.com/KhalisFoundation/KhajanaAPI

Mca-Sandeep commented 6 years ago

Hi, Is it possible to get Dasam Granth database ? can anybody help please? Any kind of help is highly appreciated.

bogas04 commented 6 years ago

@Mca-Sandeep please refer to https://github.com/sikher/gurbanidb/issues/10#issuecomment-285968239 which makes use of ShabadOS API by KhalisFoundation

const Khajana = require('khajana');
const url = Khajana.buildApiUrl({ source: 'D', ang: 12 });

fetch(url)
  .then(r => r.json())
  .then(r => console.log(r));

@jhbsk you can get some insight about API here

Mca-Sandeep commented 6 years ago

Thanks you @bogas04 ,

Actually we want to customize the database the way we want to.... The source you mentioned is no doubt awesome. But user has to have internet connection all the time to hit web api.

bogas04 commented 6 years ago

Hmm. You might want to contact KhalisFoundation in that case, they might be able to provide you a DB.

On Wed, Jan 10, 2018, 11:55 PM Mca-Sandeep notifications@github.com wrote:

Thanks you @bogas04 https://github.com/bogas04 ,

Actually we want to customize the database the way we want to.... The source you mentioned is no doubt awesome. But user has to have internet connection all the time to hit web api.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sikher/gurbanidb/issues/10#issuecomment-356691900, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5DVQK3nrckPzXjn4T74W1VwkaN1jZ7ks5tJQCbgaJpZM4Dh36v .

--

Regards, Divjot Singh https://bogas04.github.io/.

bogas04 commented 6 years ago

ShabadOS is basically an alliance to bring panth and individuals like you to come under one umbrella and help each other improve digital baani. Check out ShabadOS.org

On Wed, Jan 10, 2018, 11:56 PM Divjot Singh bogas04@gmail.com wrote:

Hmm. You might want to contact KhalisFoundation in that case, they might be able to provide you a DB.

On Wed, Jan 10, 2018, 11:55 PM Mca-Sandeep notifications@github.com wrote:

Thanks you @bogas04 https://github.com/bogas04 ,

Actually we want to customize the database the way we want to.... The source you mentioned is no doubt awesome. But user has to have internet connection all the time to hit web api.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sikher/gurbanidb/issues/10#issuecomment-356691900, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5DVQK3nrckPzXjn4T74W1VwkaN1jZ7ks5tJQCbgaJpZM4Dh36v .

--

Regards, Divjot Singh https://bogas04.github.io/.

--

Regards, Divjot Singh https://bogas04.github.io/.

Mca-Sandeep commented 6 years ago

Thanks divjot Singh.

On Wed, Jan 10, 2018 at 1:26 PM, Divjot Singh notifications@github.com wrote:

Hmm. You might want to contact KhalisFoundation in that case, they might be able to provide you a DB.

On Wed, Jan 10, 2018, 11:55 PM Mca-Sandeep notifications@github.com wrote:

Thanks you @bogas04 https://github.com/bogas04 ,

Actually we want to customize the database the way we want to.... The source you mentioned is no doubt awesome. But user has to have internet connection all the time to hit web api.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sikher/gurbanidb/issues/10#issuecomment-356691900, or mute the thread https://github.com/notifications/unsubscribe-auth/ AF5DVQK3nrckPzXjn4T74W1VwkaN1jZ7ks5tJQCbgaJpZM4Dh36v .

--

Regards, Divjot Singh https://bogas04.github.io/.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sikher/gurbanidb/issues/10#issuecomment-356692301, or mute the thread https://github.com/notifications/unsubscribe-auth/Ahq2PfrIJV8ugoJCFNRhWGVgBcfDXLUeks5tJQDtgaJpZM4Dh36v .

-- Regards Sandeep