search

silicon-slopes-engineer-workshop / coding_pairs

MIT License
0 stars 2 forks source link

Added styled-components. minor styling of signup component #12

Closed chadjemmett closed 5 years ago

chadjemmett commented 5 years ago

I'm not sure this will get merged, but. I wanted to see if everything was working. It does. I added styled-components to the dependencies. Wrote the styled component code in Signup.js

Screen Shot 2019-05-20 at 3 33 33 PM

Edit, here's my video on styled components. https://www.youtube.com/watch?v=JG9DxnopKas

murffious commented 5 years ago

lets do one more step to make sure this is the styling for the whole app which is related to an issue by itself - looks great to me - so before approving lets just use this to make sure this will work for styling the whole app...? just because I am not 100% sure what styled components entails etc. will look into or await further answer to that question and thanks looks great @ceejaay this will basically force all to use it and making sure we want to do that - like its fine but what are the reasons to support or maybe I dont fully get it thanks again see also CSS - Pick general site colors & theme #6

murffious commented 5 years ago

also since I now assigned you to this task #6 go ahead and if you find a pair to get them to approve and notice a small blip about the decision to all in docs will help I think - like links and small tips or whatever you can do like reasons benefits or just whatever