Adding downloads into the score calculation for ranking results

silverstripe / addons.silverstripe.org

Website hosting Silverstripe Framework extensions

BSD 3-Clause "New" or "Revised" License

13 stars 16 forks source link

Adding downloads into the score calculation for ranking results #201

Closed ScopeyNZ closed 6 years ago

ScopeyNZ commented 6 years ago

Further improvements to #200

This PR:

Adds downloads back into result ordering (but at a small factor)
Prevents the elastic search being performed 3 times per request
Ensures that matched terms are summed for each section and not just using the "max" score value.

robbieaverill commented 6 years ago

Ooooh, controversial =D hello Google!

robbieaverill commented 6 years ago

On UAT:

[User Error] Uncaught Elastica\Exception\ResponseException: org.elasticsearch.index.fielddata.plain.PagedBytesIndexFieldData cannot be cast to org.elasticsearch.index.fielddata.IndexNumericFieldData [reason: all shards failed]
GET /add-ons?search=blog&isDev=1&isDevtoken=57a8f924a47fa15347794b27fd5a1b01
Line 99 in /var/www/mysite/releases/27206fef214435be4831c7b9edf3a5acb29ba150/vendor/ruflin/elastica/lib/Elastica/Transport/Guzzle.php

ScopeyNZ commented 6 years ago

😢 - I'll look into that shortly.