silverstripe / addons.silverstripe.org

Website hosting Silverstripe Framework extensions
BSD 3-Clause "New" or "Revised" License
13 stars 16 forks source link

Ratings don't appear to be updating #210

Closed robbieaverill closed 5 years ago

robbieaverill commented 6 years ago

Example: phptek/verifiable

It's scheduled in jobs, but running the job reports a 404 in Codecov (that's fine) but also zero points overall when the job finishes.

We need to have another look at this. Note there's some other issues e.g. https://github.com/silverstripe/moduleratings/issues/11 and an open pull request to help with diagnosing this kind of problem at #209

phptek commented 6 years ago

Well at least the module score is automated now - I thought I still needed to send an email to community@silverstripe.org - indeed, I did that a couple of weeks ago because that's what the docs on addons.silverstripe.org still say.

phptek commented 6 years ago

Ah, not the same thing as "Module Score" after all. So how does one go about getting one of these for phptek/verifiable?)

robbieaverill commented 6 years ago

Has it still not updated!? Well, the PR to add logging for diagnostics was finally merged a couple of days ago so now at least we can work out why the jobs are failing. It should all be automatic

phptek commented 6 years ago

Nope. Still says "N/A" :-(

robbieaverill commented 5 years ago

@phptek still getting around to looking at fixing this. I've deployed the latest master branch to UAT which includes config for the internal ratings system to send logs to Graylog so we can try and see if there's some rate limiting being hit, or something like that. We'll hopefully be looking at this in the next couple of weeks.

robbieaverill commented 5 years ago

Logging is tricky to monitor (see #216). I didn't see anything obvious about the Travis API though. It kind of looks like some jobs aren't being run at all... will keep investigating passively

robbieaverill commented 5 years ago

🤦‍♂️ 🤦‍♂️ 🤦‍♂️

        // Provide the checksuite with a logger in case API calls fail
        $logger = new \Monolog\Logger('module_ratings_logs', [
-             new SyslogHandler('SilverStripe_log'),
+             $handler = new SyslogHandler('SilverStripe_log'),
        ]);
        $formatter = new LineFormatter("%level_name%: %message% %context% %extra%");
-         $logger->setFormatter($formatter);
+         $handler->setFormatter($formatter);
robbieaverill commented 5 years ago

Fixes are at https://github.com/silverstripe/addons.silverstripe.org/pull/217