search

silverstripe / addons.silverstripe.org

Website hosting Silverstripe Framework extensions
BSD 3-Clause "New" or "Revised" License
13 stars 16 forks source link

Update to composer v2 #256

Closed chillu closed 3 years ago

chillu commented 3 years ago

There seems to be some coupling between running the global composer binary/phar, and including the PHP libraries, as evidenced by this build failure: https://travis-ci.com/github/silverstripe/addons.silverstripe.org/builds/202246360#L463. I'm fixing this now via falling back to v1 in travis.yml

Functionally, it's unclear how long composer v1 will be supported.

robbieaverill commented 3 years ago

We probably need to update those module rating repos to work with Composer 2!

chillu commented 3 years ago

PR at https://github.com/silverstripe/addons.silverstripe.org/pull/255, side effect from investigation into OOM errors on prod.

We probably need to update those module rating repos to work with Composer 2!

Done that now: https://github.com/silverstripe/moduleratings-plugin/pull/2. But I've also removed the dependency from addons, we don't seem to need the composer plugin, just silverstripe/moduleratings which doesn't have any direct composer dependencies (no upgrade necessary)

robbieaverill commented 3 years ago

Yep, you're right. The plugin is there so you can run the module rating commands in the addons project from the command line, if you want to test it. I also used the plugin to moduleratings library when I was building it. You can remove it and use BuildTasks instead though.

chillu commented 3 years ago

Merged and pushed to prod