silverstripe / gha-run-tests

GitHub Action - CI test runner
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Add php-parallel-lint to the PHP linting CI job #21

Closed GuySartorelli closed 2 weeks ago

GuySartorelli commented 6 months ago

We use PHP Code Sniffer, but that’s not a linter. Notably, it won’t pick up on syntax errors.

We should add https://github.com/php-parallel-lint/PHP-Parallel-Lint to CI to help avoid syntax errors from sneaking in.

Notes

Acceptance criteria

PRs

maxime-rainville commented 1 month ago

If we had a syntax error, I would expect PHPUnit to start failing. I can't remember any time where our we had a syntax error that manage to sneak through this way.

Not necessarily against this, but it seems like a very marginal improvement.

GuySartorelli commented 1 month ago

It is absolutely a very marginal improvement. It's also very little work. IMO seems worth doing.