Closed GuySartorelli closed 2 weeks ago
If we had a syntax error, I would expect PHPUnit to start failing. I can't remember any time where our we had a syntax error that manage to sneak through this way.
Not necessarily against this, but it seems like a very marginal improvement.
It is absolutely a very marginal improvement. It's also very little work. IMO seems worth doing.
We use PHP Code Sniffer, but that’s not a linter. Notably, it won’t pick up on syntax errors.
We should add https://github.com/php-parallel-lint/PHP-Parallel-Lint to CI to help avoid syntax errors from sneaking in.
Notes
Acceptance criteria
_config.php
if one existsPRs