FIX Remove broken code to copy diff files to artifacts

silverstripe / gha-run-tests

GitHub Action - CI test runner

BSD 3-Clause "New" or "Revised" License

0 stars 4 forks source link

FIX Remove broken code to copy diff files to artifacts #28

Closed emteknetnz closed 2 months ago

emteknetnz commented 2 months ago

Issue https://github.com/silverstripe/.github/issues/235

This PR deletes the "copy dist file that was different to artifacts dir" functionality that doesn't actually work, and instead just sends exit code 2.

GuySartorelli commented 2 months ago

The git diff check is really there to avoid malicious actors from manually injecting payloads into dist files. Given we aren't going to accept any PRs from anyone outside the CMS Squad for CMS 4 due to the current support level, this concept seems fine.