silx-kit / h5web

React components for data visualization and exploration
https://h5web.panosc.eu/
MIT License
183 stars 18 forks source link

Link to artifact URL from PR when visual diffing fails #1547

Closed axelboc closed 8 months ago

axelboc commented 8 months ago

The upload-artifact action finally exposes an artifact-url output! This was probably their most requested features.

This means we can provide a link to download the artifacts from the PR when visual diffing fails. I do this using the create-or-update-comment action.

axelboc commented 8 months ago

Arf, I can't get this to work because of the fact that we skip pull_request events on local PRs. So I have access to the artifact-url only in jobs triggered by the push event, which don't give easy access to the PR number (since it may not exist yet). Closing for now; might revisit this at a later date.