Specifying grid-area: vis in the visualizations did introduce a regression in the end. Turns out that if a grid area identifier is not defined in the parent grid, the cell ends up on a new row/column for reasons that I don't quite clearly understand... Since we wrap all our stories with display: grid in Storybook, the high-level visualization stories were all messed up.
So I went ahead with the plan I had to pass the grid-area: vis style from @h5web/app down to the visualizations in @h5web/lib via a custom className prop. I've also added a style prop to all the visualizations.
Specifying
grid-area: vis
in the visualizations did introduce a regression in the end. Turns out that if a grid area identifier is not defined in the parent grid, the cell ends up on a new row/column for reasons that I don't quite clearly understand... Since we wrap all our stories withdisplay: grid
in Storybook, the high-level visualization stories were all messed up.So I went ahead with the plan I had to pass the
grid-area: vis
style from@h5web/app
down to the visualizations in@h5web/lib
via a customclassName
prop. I've also added astyle
prop to all the visualizations.