silx-kit / h5web

React components for data visualization and exploration
https://h5web.panosc.eu/
MIT License
165 stars 17 forks source link

Fix `grid-area` regression #1593

Closed axelboc closed 3 months ago

axelboc commented 3 months ago

Specifying grid-area: vis in the visualizations did introduce a regression in the end. Turns out that if a grid area identifier is not defined in the parent grid, the cell ends up on a new row/column for reasons that I don't quite clearly understand... Since we wrap all our stories with display: grid in Storybook, the high-level visualization stories were all messed up.

So I went ahead with the plan I had to pass the grid-area: vis style from @h5web/app down to the visualizations in @h5web/lib via a custom className prop. I've also added a style prop to all the visualizations.