silx-kit / h5web

React components for data visualization and exploration
https://h5web.panosc.eu/
MIT License
165 stars 17 forks source link

Allow downloading failing visual snapshots from CI #1597

Closed axelboc closed 3 months ago

axelboc commented 3 months ago

I pushed a commit to main, which of course introduced a pixel-level visual regression. In the future, I'd like not to have to open a PR to resolve this sort of situation.

I investigated adding a workflow_dispatch trigger on the Approve snapshots workflow, but it's too tricky since the workflow is designed to be triggered by a comment on a PR (and I don't want to introduce more duplication).

So instead, I made sure that artifacts of the e2e job include the failing snapshots. This way, if the visual diffing fails on push to any branch, I can quickly download the new snapshots, commit them, and push the fix.