search

silx-kit / h5web

React components for data visualization and exploration
https://h5web.panosc.eu/
MIT License
161 stars 17 forks source link

Replace auto-scale toggle with domain widget on line vis #1665

Closed axelboc closed 2 weeks ago

axelboc commented 3 weeks ago

As suggested in https://github.com/silx-kit/h5web/issues/1572, I replace the Autoscale toggle with a custom domain widget on the line (and complex line) visualization.

By removing the Autoscale toggle, we loose the ability to find the domain of the entire dataset and to set it automatically as the domain of the visualization.

However, the toggle also came with the side effect of triggering a fetch of the entire dataset, which could have very bad consequences with very large datasets (e.g. unresponsive server or browser), so I think removing it is a good thing. I also like the fact that the behaviour (and code) is now consistent between the line and heatmap visualizations.

Peek 2024-06-10 15-42

axelboc commented 3 weeks ago

/approve

axelboc commented 3 weeks ago

/approve