search

silx-kit / hdf5plugin

Set of compression filters for h5py
http://www.silx.org/doc/hdf5plugin/latest/
Other
66 stars 25 forks source link

Skip zstd test in inner iteration #234

Closed spanezz closed 1 year ago

spanezz commented 1 year ago

There is currently no zstd filter plugin in Debian. The test suite of python-hdf5plugin knows how to skip zstd tests accordingly, except for one inner iteration, which needs this extra check

t20100 commented 1 year ago

Hi,

The issue is not about the zstd filter plugin but about the version of the bitshuffle filter plugin: It differs between Debian and the one embedded in hdf5plugin.

Debian currently provides v3.5.1 which uses only the LZ4 compression library while hdf5plugin embeds v0.4.2 which adds the option to use either LZ4 or the ZStd compression library, thus the failing test.

The only way I see in hdf5plugin to check the version is to write a compressed dataset and check for its flags which contains the version of the filter (I'll prepare a PR for this).

t20100 commented 1 year ago

I'm closing this as PR #235 solves the issue by supporting older version of the bitshuffle filter in the test.

t20100 commented 1 year ago

FYI, we tagged a patch release 4.0.1 including PR #235 that should fix the related issue.