silx-kit / hdf5plugin

Set of compression filters for h5py
http://www.silx.org/doc/hdf5plugin/latest/
Other
62 stars 22 forks source link

Fixed SZ compression filter build options #268

Closed t20100 closed 1 year ago

t20100 commented 1 year ago

This PR changes SZ compression filter build options to fix an issue with SZ absolute mode. I added the test from issue #267

closes #267

vasole commented 1 year ago

There is a problem with line 458 of test.py

vasole commented 1 year ago

image

vasole commented 1 year ago

Why not use the core driver therefore avoiding the need to use bytes io?

vasole commented 1 year ago

We have already used it:

https://github.com/silx-kit/hdf5plugin/blob/e01716c6e4cf9e1590edec2e8e1453e9458497c8/test/test.py#LL218C20-L218C20

t20100 commented 1 year ago

Indeed, didn't though of the 'core' driver. BTW BytesIO approach does not work with old h5py

t20100 commented 1 year ago

Tests should pass now

robertu94 commented 1 year ago

When will this be available in the pip install-able copy? Should it just be there?

vasole commented 1 year ago

When will this be available in the pip install-able copy? Should it just be there?

It is already the case :)

robertu94 commented 1 year ago

Awesome! Thanks for your help on this :)

On Fri, Jun 16, 2023 at 10:46 AM V. Armando Solé @.***> wrote:

When will this be available in the pip install-able copy? Should it just be there?

It is already the case :)

— Reply to this email directly, view it on GitHub https://github.com/silx-kit/hdf5plugin/pull/268#issuecomment-1594815011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2AP5G53R4E3UY3AJJBDHTXLRWUVANCNFSM6AAAAAAZJAXHOI . You are receiving this because you commented.Message ID: @.***>