Closed t20100 closed 7 months ago
There's an issue with the release CI when building bytedelta.c
:
Due to a missing SIMD flag since HDF5PLUGIN_AVX2=False
for this build and this relies on SSSE3 instructions..
As opposed to SSE2 and AVX*, there is no compilation option to toggle the use of SSSE3.
BTW on Windows there is no /arch:SSSE3
A fix for the SSSE3 issue is proposed here: https://github.com/Blosc/C-Blosc2/pull/586
PR https://github.com/Blosc/c-blosc2/pull/586 has been merged, and this fix is included in this PR to make it work until the next release of c-blsoc2
.
A new release of C-Blosc2 (2.13.2), with the PR https://github.com/Blosc/c-blosc2/pull/586 in, has been made. Feel free to check with it.
Thanks @FrancescAlted for the quick release! I will update hdf5plugin to use it.
If CI is happy, this is ready for review.
Looks to have an issue in the release CI with a missing symbol:
Failed to load filter blosc2: /opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/hdf5plugin/plugins/libh5blosc2.so
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/hdf5plugin/_utils.py", line 142, in register_filter
lib = ctypes.CDLL(filename)
File "/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/ctypes/__init__.py", line 364, in __init__
self._handle = _dlopen(self._name, mode)
OSError: /opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/hdf5plugin/plugins/libh5blosc2.so: undefined symbol: __pow_finite
Looks to have an issue in the release CI with a missing symbol:
Failed to load filter blosc2: /opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/hdf5plugin/plugins/libh5blosc2.so Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/hdf5plugin/_utils.py", line 142, in register_filter lib = ctypes.CDLL(filename) File "/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/ctypes/__init__.py", line 364, in __init__ self._handle = _dlopen(self._name, mode) OSError: /opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/hdf5plugin/plugins/libh5blosc2.so: undefined symbol: __pow_finite
Interesting. I have never seen this myself. Looks like an issue in clang 10? https://stackoverflow.com/questions/62334452/fast-math-cause-undefined-reference-to-pow-finite
I also saw an issue with glibc >=2.31 (used in Ubuntu20.04) having removed some symbols used when compiling with -ffast-math
compared to previous versions (and here it is compiled with manylinux2014).
I'm now trying with removing -ffast-math
since it is not used in blosc2 cmake files anyway.
Missing symbol issue fixed by removing -ffast-math
and manually started release CI passes (see https://github.com/t20100/hdf5plugin/actions/runs/7828434787).
Ready for me
This PR updates the build of the blosc2 filter to add the embedded plugins and support for the blosc2 plugin system. Still need to add some tests.
closes #254