simongray / StatementAnnotator

Custom annotator for Stanford CoreNLP that annotates sentences with the underlying statements contained within them.
4 stars 0 forks source link

Should properly separate verbs connected to different subjects #35

Closed simongray closed 8 years ago

simongray commented 8 years ago

skaermbillede 2016-06-24 13 59 21

As can be seen here, the conj:and connects the verbs in either case, so the only difference in dependency is in the nsubj relations. This results in "she hates and loves" in the second example, which is not correct.

simongray commented 8 years ago

Potential way to fix it

Create a new method to replace makeRelationsMap() for the VerbFinder. This method creates sets of conjunct verbs based on the nsubj relation. If two nsubj relations share the same governor (= parent) then they are conjunct, if not they are disjunct. This method could be called findJointlyGoverned() or something and would return a list of sets of related words based on a relation, e.g. nsubj. Whichever one has the lowest index could be used as primary, but it doesn't seem to matter much.

simongray commented 8 years ago

Fixed in 91a3481d28f658ba565b020de36decf2a1d07563