simonw / datasette-graphql

Datasette plugin providing an automatic GraphQL API for your SQLite databases
https://datasette-graphql-demo.datasette.io/
Apache License 2.0
101 stars 6 forks source link

Datasette.config() is being renamed to .setting() #66

Closed simonw closed 3 years ago

simonw commented 3 years ago

Most of these use plugin_config which is unaffected. It looks like the only code I need to worry about is this trick in datasette-graphl: https://github.com/simonw/datasette-graphql/blob/483c9a9e203bb90365def3df8b8f01dda1e75865/datasette_graphql/utils.py#L456-L460

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1107#issuecomment-733245097

simonw commented 3 years ago

If I add a setting() method here in addition to the .config() method then the plugin will work against Datasette both before and after the method is renamed.