Closed beenanner closed 8 years ago
Yeah. It should work just like your example.
Looks like this guy is the culprit.
...
var revisionedFile = relPath(firstFileBase, file.path);
var originalFile = path.join(path.dirname(revisionedFile), path.basename(file.revOrigPath)).replace(/\\/g, '/');
manifest[originalFile] = revisionedFile;
cb();
}, function (cb) {
// no need to write a manifest file if there's nothing to manifest
if (Object.keys(manifest).length === 0) {
cb();
return;
}
...
The following is returning true since the files are not written to disk.
if (Object.keys(manifest).length === 0)
Doesn't seem like a major use case to me.
It should already do this. If it doesn't, there's a bug.
@bobthecow ok, I will add a test for it then.
@beenanner I just checked and it works. Please use the latest version.
I'll check it out thanks @bobthecow and @torifat
Is there a way to only dump the manifest file? It would be nice to allow dumping of the manifest file only. A developer would then be able to setup their app to look up the rev version or just fallback to the non-rev version if not found in the manifest for whatever reason. Of course a rewrite rule would be required to support proxying the non-rev versions for the rev version request, but it avoids dumping 2 of each file. Thoughts?