Fixed docs to use cwd instead of base for manifest merging

sindresorhus / gulp-rev

Static asset revisioning by appending content hash to filenames: `unicorn.css` → `unicorn-d41d8cd98f.css`

MIT License

1.54k stars 217 forks source link

Fixed docs to use cwd instead of base for manifest merging #148

Closed ghost closed 8 years ago

ghost commented 8 years ago

Fixes at least a part of #123 . The docs are incorrect, because vinyl-file's read method doesn't take base under consideration to build up the file path, only the cwd. See https://github.com/sindresorhus/vinyl-file/blob/master/index.js#L17

leventebalogh commented 8 years ago

How are you going with this guys? Do you need any help on this? It would be good to merge it in, as the manifest.json merge functionality is still not working for me properly. Just let me know if you need any help.

sindresorhus commented 8 years ago

This PR is outdated and broken. Happy to consider this change in a new PR :)

ghost commented 8 years ago

@sindresorhus I'll send a new one in a bit :)