search

sindresorhus / gulp-rev

Static asset revisioning by appending content hash to filenames: `unicorn.css` → `unicorn-d41d8cd98f.css`
MIT License
1.54k stars 218 forks source link

Refactor tests #176

Closed benbieler closed 7 years ago

benbieler commented 8 years ago

Description

Currently the tests.js file is IHMO way to long (373 lines)... This should be split up.

What about using a nother testing framework e.g. mocha + chai?

benbieler commented 8 years ago

@sindresorhus whats your take?

lukeed commented 8 years ago

The length of the tests file is pretty much irrelevant. Given the fact that this is a node utility (and that it's a Sindre™ package), AVA should be the would-be test framework.

kevva commented 8 years ago

Yup, converting them to ava would be highly appreciated. Look at https://github.com/sindresorhus/gulp-imagemin/blob/master/test.js for inspiration.

sindresorhus commented 8 years ago

What @kevva said.