search

sindresorhus / gulp-rev

Static asset revisioning by appending content hash to filenames: `unicorn.css` → `unicorn-d41d8cd98f.css`
MIT License
1.54k stars 217 forks source link

Sourcemaps being piped further #190

Closed mbrevda closed 7 years ago

mbrevda commented 8 years ago

Description

In the following snippet, should sourcemaps be passed to the fn call on the last line? Until recently (about a 30-60 days ago) they weren't. Recently, my builds started failing. It's seems the reason is that .map files are passed in (and they don't include a revOrigPath property, causing path() to freak out, which is probably a whole different issue).

I'm trying to determine what changed: is there something that was added recently that would cause sourcemaps to be passed down the chain? Until recently, only the filename passes to gulp.source would show up there.

Thanks!

Steps to reproduce

            .pipe(rev())
            .pipe(gulpif(opts.ciBuild && !opts.prod, sourcemaps.write('./')))
            .pipe(gulp.dest(buildDir))
            .pipe(fn(function(file) {
zhouzi commented 7 years ago

Hey @mbrevda! I'm going through the issues and wanted to know if you had a chance to figure this one out? Have you solved it and/or have some pointers to share? Thanks!

mbrevda commented 7 years ago

I don't know the answer. I no longer use this.

zhouzi commented 7 years ago

Okay, thank you for sharing anyway! 👍