singnet / opencog

A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)
http://wiki.opencog.org/w/Development
Other
14 stars 3 forks source link

Ghost - Name prefix with Capital letter are not being matched #31

Closed simonmekit closed 5 years ago

simonmekit commented 5 years ago

Recreated from opencog#3266

Words starting with capital letter inside quoted phrases are not being matched.

scheme@(guile-user) [1]> (ghost-parse "goal: (dummy_goal = 0.5)") scheme@(guile-user) [1]> (ghost-parse "u: ( \" Dr. Watson \") How may I help you?") scheme@(guile-user) [1]> (test-ghost "Dr. Watson") $1 = () scheme@(guile-user) [1]> (ghost-parse "u: (\" dr. watson \") How may I help you?") scheme@(guile-user) [1]> (test-ghost "Dr. Watson") $2 = () scheme@(guile-user) [1]> (test-ghost "dr. watson") [2018-07-25 13:17:49:756] [INFO] [say] (How may I help you ?) $3 = ((WordNode "How") (WordNode "may") (WordNode "I") (WordNode "help") (WordNode "you") (WordNode "?") ) scheme@(guile-user) [1]>

leungmanhin commented 5 years ago

I'll look into this

simonmekit commented 5 years ago

running using ghost-parse-file command has also similar behavior. I think it can be treated in similar way like the one you fixed here.

leungmanhin commented 5 years ago

Yes this is also related to how the actual sentence is parsed, e.g. "Dr." and "dr." are different, while authors would consider them to be the same as in a case insensitive string match.

leungmanhin commented 5 years ago

Should be fixed in https://github.com/singnet/opencog/pull/33

simonmekit commented 5 years ago

yes #33 solves it.