sipcapture / homer

HOMER - 100% Open-Source SIP, VoIP, RTC Packet Capture & Monitoring
https://sipcapture.org
GNU Affero General Public License v3.0
1.61k stars 240 forks source link

alphabet capture-id #549

Closed hnimminh closed 2 years ago

hnimminh commented 2 years ago

can we set the capture id as numeric alphabet, example: dev-server-1? https://github.com/sipcapture/heplify-server/blob/842d096811ca91f58a6dd6137f4c61f0ef983273/rotator/mariafiles.go#L71

        capture_id varchar(100) NOT NULL DEFAULT '',

on the https://github.com/freeswitch/sofia-sip/blob/18ce20ba40f9112876448c74d0aacbce0e34b372/libsofia-sip-ua/msg/msg_internal.h#L137

    uint16_t captid;          /* Capture ID node */

currently seemly capture_id support integer only

lmangani commented 2 years ago

Hello @hnimminh

That's correct capture_id only supports integers and this is fully intentional. This said, HEP allows many other chunk types such as the optional node-name parameter which is supported by HEPlify, Captagent, RTPAgent, etc. Unfortunately FS does not but you it would be a pretty simple PR - or use another agent as a HEP proxy.

hnimminh commented 2 years ago

Thanks @lmangani,