search

sipcapture / homer

HOMER - 100% Open-Source SIP, VoIP, RTC Packet Capture & Monitoring
https://sipcapture.org
GNU Affero General Public License v3.0
1.61k stars 240 forks source link

Add capture node name for freeswitch native capture agent #551

Closed hnimminh closed 1 year ago

hnimminh commented 2 years ago

Hi @lmangani , I'm trying to add support nodename to header some how it doesn't work, I try to find out but no luck, can you help by take a look into this: https://github.com/freeswitch/sofia-sip/compare/master...hnimminh:sofia-sip:homer-capture-support-nodename

very appreciate !

kYroL01 commented 1 year ago

Hi @hnimminh . I see the link refers to a PR you want to send, correct ? The code seems correct at a first sight, but I need to double-check before giving you a correct answer. It also must be checked as we parse that in Homer. We will recheck and let you know.

Thanks

lmangani commented 1 year ago

I'm not at all familiar with the FS code perhaps @adubovikov could you take a look and make a suggestion?

kYroL01 commented 1 year ago

Hi @hnimminh the modification in your first answer are correct, as I review with @adubovikov . Feel free to forward that PR to freeswitch . Thank you

hnimminh commented 1 year ago

Thanks @kYroL01 @adubovikov @lmangani for your help. May I know the reason why message (send by above modification) was not show on homer, is this bug of parser in Homer?

kYroL01 commented 1 year ago

Hi @hnimminh . Not a bug. Homer has the possibility to parse and show capture-id as a name, but it's sent as a HEP information from an agent (heplify for example). Now if FS accept your PR you will see your capture-id as a string ;)

I will close this issue. In case of problems feel free to reopen

Thank you!