search

sirixdb / sirix-web-frontend

A web front-end for SirixDB based on Nuxt.js/Vue.js, D3.js and Typescript
https://sirix.io
17 stars 20 forks source link

@inject called with undefined this could mean that the class undefined has a circular dependency problem. #24

Closed pareshjoshi closed 4 years ago

pareshjoshi commented 4 years ago

With most recent changes, I started seeing these errors in console:

7d8c56d89e132e2d7879.js:2 Uncaught (in promise) Error: @inject called with undefined this could mean that the class undefined has a circular dependency problem. You can use a LazyServiceIdentifer to  overcome this limitation.
    at 7d8c56d89e132e2d7879.js:2
    at 7d8c56d89e132e2d7879.js:2
    at 7d8c56d89e132e2d7879.js:2
    at Object.<anonymous> (7d8c56d89e132e2d7879.js:2)
    at o (7d8c56d89e132e2d7879.js:2)
    at Module.569 (2c4aaddaf3f9d5a3bfbb.js:1)
    at c (9a011b95eb207f07c163.js:1)
pareshjoshi commented 4 years ago

I've a fix for this error

JohannesLichtenberger commented 4 years ago

Can we maybe add a test environment, such that this kind of stuff gets tested via a CI/CD server? Github now provides actions for instance, but maybe you know better than me what to do...

JohannesLichtenberger commented 4 years ago

Such that I won't accept PRs which break something in the first place...

pareshjoshi commented 4 years ago

Yes, we need sanity checks run. However, given you are the owner of the repo, only you can configure webhooks or integration with some of the free build/CI systems

JohannesLichtenberger commented 4 years ago

I just created a team... so, if you like to be part of the team that would be great for sure :-)

pareshjoshi commented 4 years ago

@JohannesLichtenberger - Yes, please. Do add me. I will try and setup CI to build app and run tests.

JohannesLichtenberger commented 4 years ago

You have an invite, great that you're onboard :-)