sirixdb / sirix-web-frontend

A web front-end for SirixDB based on Nuxt.js/Vue.js, D3.js and Typescript
https://sirix.io
17 stars 20 forks source link

Setup Dependency Injection #8

Closed jawahars16 closed 5 years ago

jawahars16 commented 5 years ago

Instead of having the data fetching logic directly in the component, it is always better to move that logic to service class and pass it through dependency injection. Following changes were made in this commit.

JohannesLichtenberger commented 5 years ago

Thank you so much 👍

BTW: What do you think? Should we move to Nuxt.js?

jawahars16 commented 5 years ago

Yes Nuxt.js would be a good option. 👍

JohannesLichtenberger commented 5 years ago

Already switched thanks to another contribution :-)

JohannesLichtenberger commented 5 years ago

@all-contributors please add @jawahars16 for code

allcontributors[bot] commented 5 years ago

@JohannesLichtenberger

I've put up a pull request to add @jawahars16! :tada: