search

sitespeedio / browsertime

Measure and Optimize Web Performance
https://www.sitespeed.io/documentation/browsertime/
Apache License 2.0
608 stars 137 forks source link

Expose trace start/stop #1988

Closed 92kns closed 1 year ago

92kns commented 1 year ago

Hello! I'd like to expose the start/stop for the chrome Trace similar to how it was done with the gecko profiler in https://github.com/sitespeedio/browsertime/pull/1934 and https://github.com/sitespeedio/browsertime/pull/1940

Does the implementation here make sense?

soulgalore commented 1 year ago

Hi @92kns yes that would be cool. I'll have a look tomorrow soon and will get back then.

soulgalore commented 1 year ago

Oh sorry I forgot about this, let me have a look tonight. There were a couple small fixes but I can fix those. I haven't tried the functionality yet though :)

92kns commented 1 year ago

no worries, sounds good! thanks :)

soulgalore commented 1 year ago

Thank you @92kns ! I will do follow up PR with small refactoring, just so we don't have the same functionality twice. Thank you again!

92kns commented 1 year ago

Awesome thanks!