sitespeedio / browsertime

Measure and Optimize Web Performance
https://www.sitespeed.io/documentation/browsertime/
Apache License 2.0
616 stars 136 forks source link

Add types to https://github.com/DefinitelyTyped/DefinitelyTyped #2063

Open soulgalore opened 10 months ago

soulgalore commented 10 months ago

It would be nice to add our types to DefinitelyTyped. Would love if someone could help out with this :)

uncaught commented 3 months ago

That's wild, usually people ask the other way around, to add types in favor of having the types in a third party location.

But don't bother with this repo's types. They seem to be quite useless unfortunately... you get no return types, no arguments, nothing:

image

soulgalore commented 3 months ago

Feel free to do a PR to fix returns etc, that would be great. I'm not into it and I only added it to make code completion work in VS Code. TypeScript for me is making JavaScript become Java and I don't understand how anyone would want that :)