sitespeedio / browsertime

Measure and Optimize Web Performance
https://www.sitespeed.io/documentation/browsertime/
Apache License 2.0
602 stars 137 forks source link

Add types to https://github.com/DefinitelyTyped/DefinitelyTyped #2063

Open soulgalore opened 8 months ago

soulgalore commented 8 months ago

It would be nice to add our types to DefinitelyTyped. Would love if someone could help out with this :)

uncaught commented 4 weeks ago

That's wild, usually people ask the other way around, to add types in favor of having the types in a third party location.

But don't bother with this repo's types. They seem to be quite useless unfortunately... you get no return types, no arguments, nothing:

image

soulgalore commented 3 weeks ago

Feel free to do a PR to fix returns etc, that would be great. I'm not into it and I only added it to make code completion work in VS Code. TypeScript for me is making JavaScript become Java and I don't understand how anyone would want that :)