search

sjmc11 / tourguide-js

TourGuide is a Javascript library for creating user tours and on-boarding steps for your apps.
https://tourguidejs.com
MIT License
592 stars 27 forks source link

autoScrollOffset Does not seem to work #31

Closed Thimows closed 6 months ago

Thimows commented 6 months ago

First of all, thank you so much for this library. It works amazingly well.

I did run into the issue that "autoScrollOffset' does not work. It does not seem to do anything. This could be a really powerful feature as by default the library does not center the elements when it scrolls to them.

-> https://tourguidejs.com/docs/options.html#option-autoscrolloffset

Let me know if there are any examples of this feature working and/or of this can be fixed in the next release!

sjmc11 commented 6 months ago

Hi @Thimows

Thanks for finding this issue.

The scroll offset was not being applied to step elements declared in array style, but was being applied to elements declared via data-attributes.

That should be resolved and fixed on release v0.0.14 available on NPM.

Let me know if the issue persists.

Thimows commented 6 months ago

@sjmc11 Thanks! This fixed the issue for me!