search

skeeto / w64devkit

Portable C and C++ Development Kit for x64 (and x86) Windows
The Unlicense
2.68k stars 185 forks source link

Fix a regression in Binutils 2.40 #59

Closed GalaxySnail closed 1 year ago

GalaxySnail commented 1 year ago

In Binutils 2.40, there is a regression that ld fails with MSVC lib files. Add a patch to fix it.

[1] https://github.com/msys2/MINGW-packages/issues/15469 [2] https://sourceware.org/bugzilla/show_bug.cgi?id=30079

skeeto commented 1 year ago

Thanks, GalaxySnail! The bugzilla report included a good reproduction sample, and the patch does indeed fix it. I shifted the patch up the Dockerfile to merge into my earlier sed-based "patch." I expect this is a short term fix and will be deleted the next time I update Binutils.

I wonder if this is connected in any way to #54.

GalaxySnail commented 1 year ago

I wonder if this is connected in any way to #54.

This regression first appeared in binutils 2.40, while binutils 2.39 worked well. So I think #54 may be a separate problem.