skycoin / skywire-services

0 stars 4 forks source link

Fix `make check` errors with latest golangci-lint #20

Closed 0pcom closed 1 year ago

0pcom commented 1 year ago

the following errors on make format check were addressed:

All changes to file are applied, but command-line syntax should be fixed
-file-path is deprecated. Put file name as last argument to the command(Example: goimports-reviser -rm-unused -set-alias -format goimports-reviser/main.go)
All changes to file are applied, but command-line syntax should be fixed
golangci-lint run -c .golangci.yml ./...
pkg/network-monitor/api/api.go:361:10: superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)
        } else {
            api.logger.Infof("Established %v transport to %v", transport, key)
            isUp = true
            err = api.Visor.RemoveTransport(tp.ID)
            if err != nil {
                api.logger.Warnf("Error removing %v transport of %v: %v", transport, key, err)
            }
            retrier = 0
        }
pkg/transport-discovery/store/postgres_store.go:48:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
    if err := s.client.Save(&tpRecord).Error; err != nil {
        return err
    }
pkg/transport-discovery/store/postgres_store.go:56:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
    if err := s.client.Where("transport_id = ?", id).Delete(&Transport{}).Error; err != nil {
        return err
    }
pkg/transport-discovery/store/postgres_store.go:55:45: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (s *postgresStore) DeregisterTransport(ctx context.Context, id uuid.UUID) error {
                                            ^
pkg/route-finder/store/graph_test.go:38:41: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (m *mockStore) GetTransportsByEdge(ctx context.Context, edgePK cipher.PubKey) ([]*transport.Entry, error) {
                                        ^
pkg/route-finder/store/graph_test.go:55:62: unused-parameter: parameter 'isUp' seems to be unused, consider removing or renaming it as _ (revive)
func (m *mockStore) SaveEntry(source, destiny cipher.PubKey, isUp bool) {
                                                             ^
internal/vpn/client.go:346:32: unused-parameter: parameter 'gateway' seems to be unused, consider removing or renaming it as _ (revive)
func SetupTUN(ifcName, ipCIDR, gateway string, mtu int) error {
                               ^
make: *** [Makefile:138: lint] Error 1

image