search

skydoves / ColorPickerView

🎨 Android colorpicker for getting colors from any images by tapping on the desired color.
Apache License 2.0
1.57k stars 211 forks source link

Zoom support #48

Open marcauberer opened 4 years ago

marcauberer commented 4 years ago

Hi, first of all: Thanks for your awesome lib! One feature is missing after all: Support for zooming into the image. Some images might have very tiny color spots so that it's hard to pick the colors.

I would highly appreciate, if you would implement it!

skydoves commented 4 years ago

Hi, @marcauberer This issue sounds great. It could be a nice new feature! Thank you for your issue :)

marcauberer commented 3 years ago

Any progress on this?

ahmadbajwa12315 commented 3 years ago

@skydoves any good news about this feature?

ahmadbajwa12315 commented 3 years ago

@marcauberer hi, should we wait or go for something else for this?

skydoves commented 3 years ago

Hi, I was thinking about this issue and the action is quite difficult to imagine. Zoomable means the image can be draggable with two fingers and also movable by touching the image. Hence, the zoomable actions would overlap and work together with a thumb for selecting a pixel from the image. A user wants to move the zoomed image, but the selector (thumb) will move together. (Or we need a boolean property for checking it is a zoomable mode or not). If you have any solutions for this, feel free to suggest any ideas. Thanks!

ahmadbajwa12315 commented 3 years ago

You can button for this Boolean, if the user want to zoom we can set true. That how it will work separately.

On Wed, Dec 23, 2020 at 5:43 PM Jaewoong Eum notifications@github.com wrote:

Hi, I was thinking about this issue and the action is quite difficult to imagine. Zoomable means the image can be draggable with two fingers and also movable by touching the image. Hence, the zoomable actions will overlap and work together with moving a thumb for selecting a pixel from the image. A user wants to move the zoomed image, but the selector (thumb) will move together. (Or we need a boolean property for checking it is a zoomable mode or not). If you have any solutions for this, feel free to suggest me. Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/skydoves/ColorPickerView/issues/48#issuecomment-750278781, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARRSELARF4NR576IA3H4IILSWHQXRANCNFSM4NJTTPMQ .

ahmadbajwa12315 commented 3 years ago

@skydoves So still how much time you required to lunched this feature?

skydoves commented 3 years ago

PR is open. You can contribute.