search

skygate / skyexpo-matchmaking

The matchmaking app for skyexpo AI 2020
http://skyexpo.hal.skygate.io/
0 stars 0 forks source link

Revert "Task/skyex 73 refactor login and register forms" #191

Open sojek opened 4 years ago

sojek commented 4 years ago

Reverts skygate/skyexpo-matchmaking#190

sojek commented 4 years ago

You should talk firstly with @ArkadiuszSa and then let him reverts it 👎

This is not an open-source project, the company pays for all the time devoted to the project so we have the right to require that the code be sufficiently checked.

Pull request was not fully checked and @ArkadiuszSa should listen to the rules set in the company.

sojek commented 4 years ago

@ArkadiuszSa should first talk with me or @krzysztofp, then make decisions of this type yourself, make some code quickly without a proper check, because we pay for this work, not @ArkadiuszSa

sojek commented 4 years ago

I just point that you reverted his code without any comments and explanations. Someone could still review merged pr and write comments and after that @ArkadiuszSa could revert it's on his own, I just don't see a reason for forcing revert cause there was no a good review.

I left a lot of comments and explanations on the slack channel.