REF: insert particles after Time (and Setup as a fallback); remove others always

slaclab / lume-genesis

Genesis 1.3 tools for use in LUME

https://slaclab.github.io/lume-genesis/

Apache License 2.0

4 stars 7 forks source link

REF: insert particles after Time (and Setup as a fallback); remove others always #23

Closed ken-lauer closed 3 weeks ago

ken-lauer commented 3 weeks ago

Changes

This PR adjusts initial_particles and initial_field handling:

Remove other unused Beam instances when inserting particles
Remove ImportDistribution instances when inserting an ImportBeam instance
Remove ImportBeam instances when inserting an ImportDistribution instance
Fix initial_field fallback to insert after setup (off-by-one error)

ken-lauer commented 3 weeks ago

Rebased on master

ChristopherMayes commented 3 weeks ago

That doesn't work, I think it needs to come after Time. Although Time isn't required, I'm not sure particles work without it.

ken-lauer commented 3 weeks ago

importbeam docs say:

The modules controls the import of a Genesis 1.3 particle file to replace the internal generation of the particle distribution (note that the module beam should not be called). The routine defines also the parameter for a time-dependent run if the time-namelist hasn’t been defined yet.

importfield docs say:

The modules controls the import of a Genesis 1.3 field file to replace the internal generation of the field distribution (note that the module field should only be called afterwards with the accumulate-option enabled). The routine defines also the parameter for a time-dependent run if the time-namelist hasn’t been defined yet.

If this attempt is good, should I switch up the initial field handler as well?

ChristopherMayes commented 3 weeks ago

If this attempt is good, should I switch up the initial field handler as well? Sure