MAINT: set rootname prior to writing files if user left it unset

slaclab / lume-genesis

Genesis 1.3 tools for use in LUME

https://slaclab.github.io/lume-genesis/

Apache License 2.0

4 stars 7 forks source link

MAINT: set rootname prior to writing files if user left it unset #29

Closed ken-lauer closed 3 weeks ago

ken-lauer commented 3 weeks ago

Changes

Sets setup.rootname default to output.
This avoids the scenario where the user may forget to set rootname and lume-genesis refuses to read the output.
A couple unrelated fixes made their way in here, too:
- FODO notebook global_ -> globals mistake (reverted to the correctly-named _global_ parameters)
- CI: Lint failure on main branch failing due to no-commit-to-branch pre-commit check (fix is just to check out a temporary branch)

ken-lauer commented 3 weeks ago

Tests indicate this is doing what I think it should, @ChristopherMayes. Can you please ensure you have the correct version of this branch (not a mistaken merge like last time!) and try again?