search

slamdata / purescript-echarts

Purescript bindings for Baidu's Echarts library
36 stars 16 forks source link

PureScript 0.12 #54

Open ninjarab opened 6 years ago

ninjarab commented 6 years ago

As a bunch of dependencies have been deprecated, purescript-dom has been split up into a variety of projects within the purescript-web organization and purescript-eff has been deprecated in favour of purescript-effect (or purescript-run), is there any plan for upgrading the project?

I gave it a try on my own fork, see https://github.com/Ninjarab/purescript-echarts/pull/1/files, but I have no idea if this is the right approach. I’m willing to help, if I can, though I am still pretty new to PureScript. So please feel free to take a look and to leave some comments.

cryogenian commented 6 years ago

We don't need it currently in SlamData, sorry 😞 I'll add proper review to the pr, but after brief look I think that you don't need to remove phantom rows from CommandT and DSL since this will allow to have items with axes, axes with series and other funny nonsense.

Thank you very much!