search

slub / ocrd_controller

Path to network implementation of OCR-D
MIT License
6 stars 3 forks source link

Dockerfile: add label-schema and OCI labels #31

Closed bertsky closed 1 year ago

bertsky commented 1 year ago

perhaps better this way. But I have no idea how org.opencontainers.image.base.digest is supposed to be set within Dockerfile (short of another BUILD_ARG), so I just left it out.

bertsky commented 1 year ago

Before you merge, can we trigger GHA here and take a look at the labels, comparing before/after?

markusweigelt commented 1 year ago

Before you merge, can we trigger GHA here and take a look at the labels, comparing before/after?

Yes I have created an image to test labels.

https://github.com/slub/ocrd_controller/pkgs/container/ocrd_controller/90000776?tag=labeltest

bertsky commented 1 year ago

Yes I have created an image to test labels.

https://github.com/slub/ocrd_controller/pkgs/container/ocrd_controller/90000776?tag=labeltest

That's odd. GH does not show any. docker image inspect does show all the OCI labels under Config, but there's also a null under ContainerConfig – no idea what relevance that has.

markusweigelt commented 1 year ago

That's odd. GH does not show any. docker image inspect does show all the OCI labels under Config, but there's also a null under ContainerConfig – no idea what relevance that has.

My internet is so lame i am still downloading :/