search

smaitch / Grail

World of Warcraft addon to provide a database of quest information.
31 stars 20 forks source link

LUA Errors after latest update for Wholly & Grail #232

Closed Wyr3d closed 3 years ago

Wyr3d commented 4 years ago

Grail still appears to have some issues. This popped up while I was entering Ashenvale from Mor'shan Ramparts. No idea why

Message: Interface\AddOns\Grail\Grail.lua:8791: Usage: GetGarrisonInfo(garrisonType) Time: Thu Oct 15 11:04:12 2020 Count: 1 Stack: Interface\AddOns\Grail\Grail.lua:8791: Usage: GetGarrisonInfo(garrisonType)

string "=[C]": in function GetGarrisonInfo' [string "@Interface\AddOns\Grail\Grail.lua"]:8791: in function_PhaseMatches' [string "@Interface\AddOns\Grail\Grail.lua"]:6426: in function f' [string "@Interface\AddOns\Grail\Grail.lua"]:3728: in function_AllEvaluateTrueS' [string "@Interface\AddOns\Grail\Grail.lua"]:3828: in function <Interface\AddOns\Grail\Grail.lua:3809>

[string "@Interface\AddOns\Grail\Grail.lua"]:8111: in function MeetsPrerequisites' [string "@Interface\AddOns\Grail\Grail.lua"]:10784: in functionStatusCode' [string "@Interface\AddOns\Grail\Grail.lua"]:6603: in function f' [string "@Interface\AddOns\Grail\Grail.lua"]:3728: in function_AllEvaluateTrueS' ...

[string "@Interface\AddOns\Grail\Grail.lua"]:3745: in function AncestorStatusCode' [string "@Interface\AddOns\Grail\Grail.lua"]:10786: in functionStatusCode' [string "@Interface\AddOns\Grail\Grail.lua"]:4283: in function ClassificationOfQuestCode' [string "@Interface\AddOns\Wholly\Wholly.lua"]:1434: in function_ClassifyQuestsInMap' [string "@Interface\AddOns\Wholly\Wholly.lua"]:1885: in function _ForcePanelMapArea' [string "@Interface\AddOns\Wholly\Wholly.lua"]:4417: in functionUpdateQuestCaches' [string "@Interface\AddOns\Wholly\Wholly.lua"]:963: in function ?' [string "@Interface\AddOns\Wholly\Wholly.lua"]:2532: in function_OnEvent' [string "@Interface\AddOns\Wholly\Wholly.lua"]:4433: in function <Interface\AddOns\Wholly\Wholly.lua:4433>

Locals:

yoshimo commented 4 years ago

Line ~8790 In Grail.lua needs to be currentPhase = C_Garrison.GetGarrisonInfo(Enum.GarrisonType.Type_6_0) or 0 -- the API returns nil when there is no garrison some things changed to enums in the SL Patch. Might still be missing in the curren release

smaitch commented 4 years ago

I just pushed an update to GitHub that redefines the old enum in an attempt to get this to work properly.

smaitch commented 3 years ago

Grail 112 is now released with this change.