Update evogateway.py - Githubissues

smar000 / evoGateway

Python script for listening in and responding to evohome heating control radio messages

46 stars 17 forks source link

Update evogateway.py #45

Closed gitotp closed 2 years ago

gitotp commented 2 years ago

Fix LOG_FILE_ROTATE_COUNT / LOG_FILE_ROTATE_BYTES from conf.get to conf.getint

Traceback (most recent call last): File "./evogateway.py", line 184, in file_handler = RotatingFileHandler(EVENTS_FILE, maxBytes=LOG_FILE_ROTATE_BYTES, backupCount=LOG_FILE_ROTATE_COUNT) File "/usr/local/lib/python3.8/logging/handlers.py", line 146, in init if maxBytes > 0: TypeError: '>' not supported between instances of 'str' and 'int'

davevleugel commented 2 years ago

temporary fix delete in evogateway.cfg

LOG_FILE_ROTATE_COUNT = 9 LOG_FILE_ROTATE_BYTES = 1000000

I dont know the right fix, but this helps

smar000 commented 2 years ago

Thanks for the pull request. Entirely an oversight when quickly added config file support for these two parameters.

gitotp commented 2 years ago

You're welcome and no doubt it was an oversight. Happy to help with this great repository/software you created.