search

smartcar / go-sdk

Smartcar's Go SDK
MIT License
5 stars 0 forks source link

Add country support #20

Closed rsimari closed 3 years ago

rsimari commented 3 years ago

https://app.asana.com/0/1185123266141337/1191525787597415/f

codecov[bot] commented 3 years ago

Codecov Report

Merging #20 into master will decrease coverage by 2.32%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   84.27%   81.94%   -2.33%     
==========================================
  Files           5        5              
  Lines         318      277      -41     
==========================================
- Hits          268      227      -41     
  Misses         37       37              
  Partials       13       13
Impacted Files Coverage Δ
vehicle.go 71.42% <ø> (-5.15%) :arrow_down:
authentication.go 90.32% <100.00%> (-0.31%) :arrow_down:
smartcar.go 93.65% <100.00%> (-0.95%) :arrow_down:
utils.go 100.00% <100.00%> (ø)
requests.go 70.21% <0.00%> (-4.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a95c57c...79bf185. Read the comment docs.

s-ashwinkumar commented 3 years ago

a bunch of places have alignment issues, i am not sure whats going on there and wht the linter didnt catch it. Please look over it, these are places with country being used

smartcar-ci commented 3 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: