Implement i128/u128 - Githubissues

smessmer / binary-layout

The binary-layout library allows type-safe, inplace, zero-copy access to structured binary data. You define a custom data layout and give it a slice of binary data, and it will allow you to read and write the fields defined in the layout from the binary data without having to copy any of the data. It's similar to transmuting to/from a #[repr(packed)] struct, but much safer.

Apache License 2.0

66 stars 9 forks source link

Implement i128/u128 #4

Closed ckaran closed 2 years ago

ckaran commented 2 years ago

I figured out my error, and it was a dumb one; I overlapped the ranges of bytes of two separate values. As a result, the tests failed because bytes were overwritten when they shouldn't have. Everything should work now.

smessmer commented 2 years ago

Thank you, this looks great. Can I ask you to add the following?

Test cases to https://github.com/smessmer/binary-layout/blob/master/src/fields/wrapped.rs
A changelog entry for the next version
Mention i128/u128 in the doc comments of https://github.com/smessmer/binary-layout/blob/master/src/lib.rs in Supported field types / Primitive integer types. Also, you may have to run the gen_readme.sh script afterwards since the README is generated from that documentation.

ckaran commented 2 years ago

Done. Please let me know if there is anything else I should do to fix this PR. I have some thoughts for other PRs as well, I'll open separate issues for them.

smessmer commented 2 years ago

Thank you :)